refactor: updated voice snippets #176
Open
+179
−418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manchuck
force-pushed
the
update-voice-snippets
branch
from
c5a0755 to
404211a
Compare
manchuck
requested review from
dragonmantank,
SMadani and
Tr00d
and removed request for
dragonmantank
SMadani
requested changes
Feb 26, 2025
voice/connect-synchronous.js
Outdated
| const port = process.env.PORT || 3000; | ||
| const VONAGE_FROM_NUMBER = process.env.VONAGE_FROM_NUMBER; | ||
| const VONAGE_TO_NUMBER = process.env.VONAGE_TO_NUMBER; | ||
| const VONAGE_ALT_NUMBER = process.env.VONAGE_ALT_NUMBER; |
There was a problem hiding this comment.
It is used on line 26. I'm not fully sure if this needs to change to VOICE_TO_NUMBER
manchuck
force-pushed
the
update-voice-snippets
branch
2 times, most recently
from
b58bbbf to
eea396e
Compare
manchuck
force-pushed
the
update-voice-snippets
branch
from
eea396e to
705f937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist