Spec the Observer#takeUntil() operator
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benlesh and @keithamus I'd appreciate a review on the method in https://pr-preview.s3.amazonaws.com/WICG/observable/pull/103.html#dom-observable-takeuntil. |
keithamus
approved these changes
Jan 23, 2024
benlesh
approved these changes
Jan 24, 2024
|
Thanks! |
github-actions bot
added a commit
that referenced
this pull request
Jan 24, 2024
SHA: 5b136db Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like one of the more complicated operators, so hopefully the attempt here is sound.
The corner cases around this one are ensuring that we properly unsubscribe from
|notifier|and|sourceObservable|simultaneously whenever we need to. This PR has a lot of documentation, so I'll direct the reader's attention to the text there which describes the mechanics I've put in place to hopefully get it all right.WPTs incoming.
Prototype implementation in Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/5228477.
Preview | Diff