Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReSpec no longer seems to allow {{[internal slot]}} references #143

Closed
domenic opened this issue Jul 12, 2021 · 0 comments · Fixed by #144
Closed

ReSpec no longer seems to allow {{[internal slot]}} references #143

domenic opened this issue Jul 12, 2021 · 0 comments · Fixed by #144

Comments

@domenic
Copy link
Collaborator

domenic commented Jul 12, 2021

https://github.com/WICG/serial/runs/3049453994?check_suite_focus=true shows some expected failures since whatwg/streams#1130 isn't merged yet, but also a lot of other failures due to ReSpec no longer liking the {{[internal slot]}} syntax. Probably those will need to be fixed on main before any further PRs are deployed.
reillyeon added a commit that referenced this issue Jul 12, 2021
@reillyeon
Reference interface name in internal slots
4485b62 
ReSpec has been updated to require a reference to the interface defining
an internal slot.

Fixes #143.
@reillyeon reillyeon mentioned this issue Jul 12, 2021
Merged
reillyeon added a commit that referenced this issue Jul 12, 2021
@reillyeon
Reference interface name in internal slots (#144)
bd037b2 
ReSpec has been updated to require a reference to the interface defining
an internal slot.

Fixes #143.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reference interface name in internal slots WICG/serial
1 participant
@domenic