Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for images being misaligned in paragraphs #1747

Merged
merged 3 commits into from
Jul 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ though this project doesn't succeed in adhering to [Semantic Versioning](https:/
- Added support for `wp_body_open` hook below opening body tag. [Pull request #1735](https://github.com/INN/largo/pull/1735) for [issue #1698](https://github.com/INN/largo/issues/1698).
- Added `font-display: block` to `fontello` font family. [Pull request #1742](https://github.com/INN/largo/pull/1742) for [issue #1686](https://github.com/INN/largo/issues/1686).
- Replaced image settings in the Largo Series Posts widget to mirror the image settings in the Largo Recent Posts widget. [Pull request #1734](https://github.com/INN/largo/pull/1734) for [issue #1727](https://github.com/INN/largo/issues/1727).
- Adds a temporary shim to fix left/right aligned images not being correctly aligned with paragraphs. [Pull request #1747](https://github.com/INN/largo/pull/1747) for [issue #1731](https://github.com/INN/largo/issues/1731).

## [Largo 0.6.3](https://github.com/INN/largo/compare/v0.6.2...v0.6.3)

Expand Down
16 changes: 15 additions & 1 deletion css/style.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/style.min.css

Large diffs are not rendered by default.

19 changes: 19 additions & 0 deletions less/inc/gutenberg-shim-16241.less
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/*
* This is a shim to fix left/right aligned images being misaligned with paragraphs.
* Largo issue: https://github.com/INN/largo/issues/1731
* Gutenberg issue: https://github.com/WordPress/gutenberg/issues/16241
*/

.entry-content {
.wp-block-image {
.alignleft {
display: inline-table;
}
.alignright {
display: inline-table;
}
}
}
div.wp-block-image {
margin: auto;
}
5 changes: 5 additions & 0 deletions less/style.less
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,8 @@
@import "inc/responsive-768px-979px.less";
@import "inc/responsive-767px-max.less";
@import "inc/print.less";

// --------------------------------------------
// Current shims
// --------------------------------------------
@import "inc/gutenberg-shim-16241.less";