-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post social icon styles updates #951
Conversation
…gle.less and the coloration styles should go in .post-social? Or create a shared style?
What's with the weird left margin when it's at the bottom of the post? |
#950 is what's up. Should I tackle that here? |
yes. |
Updated with a fix for #950 and new screenshots. |
Now with proper |
…r the content of the buttons, make sure the email hover state uses the pointer cursor
Going to merge this to We'll still need a thorough check of member themes before we're able to deploy this. |
@benlk the email button is not working for me, is that a known issue? |
Unless it's #799, it's not a known issue. |
Changes
.left
and.right
grouping of social icons.widget
and puts it on#sidebar .widget
..icon-email
class on containingspan.email
with ani.icon-email
inside the span, for consistency.hidden-phone
to the text labels..largo-follow
to the post social icons at the top of the article page, so that that grabs styles from the Largo Follow widget for coloration of buttons. (This could be done the other way around as well: copy the Largo Follow styles into the post social section ofsingle.less
and then add their class to the Largo Follow widget.)Width of 420 px, approximately phone-like:
Width of 769 px, the smallest at which the labels will show.
The padding on the left of these icons is because of the problem described in #950.
Why
For WE-18, and Women's eNews and RNS.
For #950, which had the problem where widgets in the article-bottom position were not as wide as the column:

## Questions - [ ] should I move the coloration styles out of `.largo-follow`? - [x] should this fix #950?