Fix/frontier block import #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Local syncing tests have confirmed that the Ethereum block syncing issues are no longer present with this change. |
Moliholy
approved these changes
Aug 15, 2023
peterwht
added a commit
that referenced
this pull request
Aug 15, 2023
* fix: remove frontier_block_import to fix syncing issue polkadot-evm/frontier#603
peterwht
added a commit
that referenced
this pull request
Aug 16, 2023
* chore: move xcm custom tests to their own folder * feat: add pallet-did-precompiles to runtime * Fix/frontier block import (#136) * fix: remove frontier_block_import to fix syncing issue polkadot-evm/frontier#603 * feat: add integration test to add did * feat: add integration test for updating a did * feat: add integration test to remove dids * refactor: improve custom integration tests * feat: add integration test to add DID services * feat: add integration test to remove did services * feat: add integration tests to add did credentials * feat: add integration test to revoke issuer * feat: add integration test to revoke did credentials --------- Co-authored-by: Peter White <[email protected]>
peterwht
added a commit
that referenced
this pull request
Aug 16, 2023
* feat(did): adding in create_did precompile * test(did): adding mock * test(did): added tests for happy path of create did * feat(did): added WatrDID solidity interface * feat(did): added all publicly callable functions to precompile * feat(did): implemented remove_did and tests * refactor(did): update create_did to allow for array of services * test(did): add test for incorrect input in create did * feat(did): add in add/remove did services implementation, refactor * test(did): added tests for adding/removing did services * Remove optional parameter to create DID * make parameters optional in precompiles * add precompile for update_did * add precompile to issue credentials * add precompile to revoke credentials * update solidity interface for DID * use raw bytes when adding did services in precompiles * ensure then right number of parameters is present * improve readability in precompiles * syntax improvements * update evm function selectors * feat(did): adding in create_did precompile * test(did): adding mock * test(did): added tests for happy path of create did * feat(did): added WatrDID solidity interface * feat(did): added all publicly callable functions to precompile * feat(did): implemented remove_did and tests * refactor(did): update create_did to allow for array of services * test(did): add test for incorrect input in create did * feat(did): add in add/remove did services implementation, refactor * test(did): added tests for adding/removing did services * use evm strings instead of bytes where needed * chore(fmt): fixing formatting errors * fix: tests for did precompiles * Add integration tests for the DID pallet precompiles (#137) * chore: move xcm custom tests to their own folder * feat: add pallet-did-precompiles to runtime * Fix/frontier block import (#136) * fix: remove frontier_block_import to fix syncing issue polkadot-evm/frontier#603 * feat: add integration test to add did * feat: add integration test for updating a did * feat: add integration test to remove dids * refactor: improve custom integration tests * feat: add integration test to add DID services * feat: add integration test to remove did services * feat: add integration tests to add did credentials * feat: add integration test to revoke issuer * feat: add integration test to revoke did credentials --------- Co-authored-by: Peter White <[email protected]> --------- Co-authored-by: José Molina <[email protected]> Co-authored-by: Peter White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontier / EVM was not present at Genesis. So, when a collator is syncing it will reject blocks due to an Ethereum block not being found. This is outlined in the following issue: polkadot-evm/frontier#603.
This PR solves the issues by removing the
FrontierBlockImportwrapper. TheMappingSyncWorkerfor Frontier is still present.