-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example notebook with JUMP UMAP processing #88
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this analysis! I made some (mostly minor) comments to think about and potentially improve the work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this as I don't see this needing much more changes.
I am a bit confused by how the embeddings are connected back to the cosmicqc outlier status. Maybe more clarity would help me understand, since to me that could be impacting the pattern in the UMAPs.
Other than that, exciting to get this created! Feel free to merge or ask for further feedback after addressing comments.
docs/src/examples/images/umap_elongated_nuclei_outliers_BR00117012.png
Outdated
Show resolved
Hide resolved
docs/src/examples/images/umap_erroneous_outliers_BR00117012.png
Outdated
Show resolved
Hide resolved
docs/src/examples/images/umap_large_nuclei_outliers_BR00117012.png
Outdated
Show resolved
Hide resolved
Co-Authored-By: Jenna Tomkinson <[email protected]> Co-Authored-By: Gregory Way <[email protected]>
Co-Authored-By: Jenna Tomkinson <[email protected]> Co-Authored-By: Gregory Way <[email protected]>
Thanks @gwaybio and @jenna-tomkinson for your earlier reviews! I've added a bunch of changes based on what you mentioned and this could use another look when there's a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤩
No need to address the following comment (and the three comments below), I think you're good to go:
FWIW, my "killer app" idea involved aggregating data with and without outliers, then applying UMAP to both of these aggregated datasets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left some minor comments for you to address but feel free to merge when ready!
docs/src/examples/images/umap_comparison_with_and_without_erroneous_outliers_BR00117012.png
Outdated
Show resolved
Hide resolved
docs/src/examples/images/umap_large_nuclei_outliers_BR00117012.png
Outdated
Show resolved
Hide resolved
Co-Authored-By: Jenna Tomkinson <[email protected]> Co-Authored-By: Gregory Way <[email protected]>
Thanks so much @jenna-tomkinson and @gwaybio for your reviews! I've addressed all comments and added new figures based on the results. I'll now merge this in. |
Description
This PR adds an example notebook to help demonstrate coSMicQC use with JUMP by performing a UMAP analysis. The output generally show where outliers occur within the embeddings from a sample of BR00117012 sourced from the cpg0000-jump-pilot JUMP dataset.
Additional notes:
cosmicqc_in_a_nutshell
notebook which recently was reorganized / was lacking display of outlined cells within the CytoDataFrame.Thanks for any feedback you may have!
Closes #23
Closes #83
Closes #90
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.