Fix plates 1 and 2 IC + rerun #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
It looks like the dataframes are identical for both plates 3 and 3' across all datasets |
MattsonCam
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Good job overall! This was a smaller pr than I expected. I made a few comments, but if you want feedback on anything else specifically, just let me know. I'll tag you just in case @jenna-tomkinson .
|
@MattsonCam Thank you for the review! I will be merging now! |
jenna-tomkinson
added a commit
to jenna-tomkinson/nf1_schwann_cell_painting_data
that referenced
this pull request
Jun 13, 2023
Merge pull request WayScience#14 from jenna-tomkinson/fix_plates_1_2_ic_runs
jenna-tomkinson
added a commit
that referenced
this pull request
Jun 13, 2023
Add Cameron's suggestions from PR #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the CellProfiler pipeline for illumination correction in this PR and reran these plates through CellProfiler analysis.
I reran the code to run through the processing of the outputted SQLite files. I noticed that VSCode determined that Plates 3 and 3 prime are different for normalization and feature selection. @MattsonCam, Can you please confirm that these reruns for plates 3 and 3 prime did not change the values?