Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plate 3 analysis without run #9

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

jenna-tomkinson
Copy link
Member

In this PR, I create the setup for running plate 3 with a new analysis pipeline specifically for the next two plates (3 and 3').

I do not run this pipeline in this PR since running on the Mac w/ M2 Pro Chip is not fast and will take a longer time than running on the Linux machine. The next PR will be running the analysis and running CytoTable to merge single cells.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MikeLippincott
Copy link
Member

Good PR. Please check in with Dave about the eval function. Other than that. LGTM

@jenna-tomkinson jenna-tomkinson requested a review from d33bs April 14, 2023 16:27
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a few comments, please don't hesitate to let me know if you have any questions. I had one comment in regards to the filepaths used for plates_info_dictionary which may need attention, otherwise I thought thing LGTM.

@jenna-tomkinson
Copy link
Member Author

@d33bs @MikeLippincott Thank you both for the review! I will now be merging this and then running the analysis on fig for plate 3.

@jenna-tomkinson jenna-tomkinson merged commit 527c3f5 into WayScience:main Apr 17, 2023
@jenna-tomkinson jenna-tomkinson deleted the add_plate3_analysis branch April 17, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants