[NFC] Avoid huge output in validator messages #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
changed the title
tlively
reviewed
Feb 28, 2025
| // already very large. This avoids quadratic output in some cases (e.g. if | ||
| // we have many nested expressions in each other, all of which fail to | ||
| // validate). | ||
| const std::ostringstream::pos_type MAX_OUTPUT = 100 * 1024; |
There was a problem hiding this comment.
Should this be lower? 100KB seems like much more than would actually be useful to look at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested expressions that all fail to validate can lead to quadratic output
and OOMs. Instead, put a limit on the size we print, and after it only
emit truncated error messages of fixed size.
Also make some of the types more precise in this code, which makes
it easier to read.
Fixes #7333