Add a custom descriptors feature #7339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the proposal is called "Custom RTTs," the more precise term for its main feature is "custom descriptors." To decrease long-term confusion at the expense of some possible short-term confusion, name the corresponding new feature "custom descriptors." This feature will guard the use of both descriptor/describes clauses and exact reference types.
kripken
approved these changes
Mar 3, 2025
src/tools/tool-options.h
Outdated
| @@ -106,6 +106,8 @@ struct ToolOptions : public Options { | |||
| .addFeature(FeatureSet::StackSwitching, "stack switching") | |||
| .addFeature(FeatureSet::SharedEverything, "shared-everything threads") | |||
| .addFeature(FeatureSet::FP16, "float 16 operations") | |||
| .addFeature(FeatureSet::CustomDescriptors, | |||
| "custom descriptors and exact references") | |||
There was a problem hiding this comment.
Suggested change
| "custom descriptors and exact references") | |
| "custom descriptors (RTTs) and exact references") |
There was a problem hiding this comment.
Might help avoid some confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the proposal is called "Custom RTTs," the more precise term for
its main feature is "custom descriptors." To decrease long-term
confusion at the expense of some possible short-term confusion, name the
corresponding new feature "custom descriptors." This feature will guard
the use of both descriptor/describes clauses and exact reference types.