[js-api] Specify changes to Module, Memory, Table and Global. #17
Conversation
|
@rossberg wondering if we can merge this |
document/js-api/index.bs
Outdated
| @@ -596,16 +645,24 @@ interface Instance { | |||
| <h3 id="memories">Memories</h3> | |||
|
|
|||
| <pre class="idl"> | |||
| dictionary MemoryDescriptor { | |||
| required [EnforceRange] unsigned long initial; | |||
| dictionary InitialMemoryDescriptor { | |||
There was a problem hiding this comment.
Why not express this as derived from MemoryType?
There was a problem hiding this comment.
I don't recall, I can change if you'd like me to.
There was a problem hiding this comment.
Same here, this is best seen as a minor variation of the "main" type.
document/js-api/index.bs
Outdated
| @@ -706,19 +782,28 @@ enum TableKind { | |||
| // e.g., typed function references, typed GC references | |||
| }; | |||
|
|
|||
| dictionary TableDescriptor { | |||
| dictionary InitialTableDescriptor { | |||
There was a problem hiding this comment.
Annoyingly, I had to comment out the constructor with this change due to plinss/widlparser#62.
| required ExternKind kind; | ||
| AnyExternType type; |
There was a problem hiding this comment.
The proposal factors these fields out into a superclass ExternType that is common to both ModuleImport- and ModuleExportDescriptor. Probably makes no observable difference at the moment, but the notion of ExternType is meaningful separately from import/export names, to describe the type of an extern object themselves, and may come in handy in future extensions.
There was a problem hiding this comment.
I'd be inclined to wait with this change until it's needed, but don't feel strongly. Let me know?
There was a problem hiding this comment.
I think I'd vote for doing it now, since it makes the relationship between the types clearer and avoids rethinking it in the future.
|
@rossberg ping |
|
@rossberg I don't have push access here; could you push the button? Thanks! |
No description provided.