Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COTECH-1245 Remove all remaining Wirewax code #244

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Conversation

andrzejkupczyk
Copy link
Contributor

COTECH-1245

Copy link

github-actions bot commented Jul 24, 2024

📊 Package size report   -0.93%↓

File Before After
README.md 6.4 kB -1.73%↓6.3 kB
Total (Includes all files) 12.0 kB -0.93%↓11.9 kB
Tarball size 4.6 kB -1.16%↓4.6 kB
Unchanged files
File Size
package.json 5.6 kB

🤖 This report was automatically generated by pkg-size-action

@andrzejkupczyk andrzejkupczyk requested a review from a team July 24, 2024 08:22
@nandy-andy
Copy link
Contributor

I wouldn't remove old directory because I connect it somehow with: https://github.com/Wikia/unified-platform/blob/master/package.json#L64. Rest of the changes LGTM like a nice clean up 👍

This reverts commit 384df09.
@andrzejkupczyk
Copy link
Contributor Author

Thanks, @nandy-andy. I anticipated this and removed it in a simple, easily reversible commit. The old directory is back. Thanks for checking 👍🏻

@andrzejkupczyk andrzejkupczyk merged commit 82f8884 into master Aug 1, 2024
2 checks passed
@andrzejkupczyk andrzejkupczyk deleted the COTECH-1245 branch August 1, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants