Skip to content

Commit

Permalink
Fix RTL styling for Media Text block (#18764)
Browse files Browse the repository at this point in the history
* Add proper !rtl ignore comments to maintain styling on RTL

* Tweak comment

* Add direction: ltr (not ignored) to the content container
  • Loading branch information
richtabor authored Jan 28, 2020
1 parent e64c554 commit 8c3bd8e
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions packages/block-library/src/media-text/style.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
.wp-block-media-text {
// This block's direction should not be manipulated by rtl, as the mediaPosition control does.
/*!rtl:begin:ignore*/
direction: ltr;
/*!rtl:end:ignore*/
display: grid;
grid-template-rows: auto;
grid-template-columns: 50% 1fr;
grid-template-rows: auto;

.has-media-on-the-right {
grid-template-columns: 1fr 50%;
}
Expand Down Expand Up @@ -29,26 +34,35 @@
}

.wp-block-media-text .wp-block-media-text__media {
/*!rtl:begin:ignore*/
grid-column: 1;
grid-row: 1;
/*!rtl:end:ignore*/
margin: 0;
}

.wp-block-media-text .wp-block-media-text__content {
direction: ltr;
/*!rtl:begin:ignore*/
grid-column: 2;
grid-row: 1;
word-break: break-word;
/*!rtl:end:ignore*/
padding: 0 8% 0 8%;
word-break: break-word;
}

.wp-block-media-text.has-media-on-the-right .wp-block-media-text__media {
/*!rtl:begin:ignore*/
grid-column: 2;
grid-row: 1;
/*!rtl:end:ignore*/
}

.wp-block-media-text.has-media-on-the-right .wp-block-media-text__content {
/*!rtl:begin:ignore*/
grid-column: 1;
grid-row: 1;
/*!rtl:end:ignore*/
}

.wp-block-media-text > figure > img,
Expand Down

0 comments on commit 8c3bd8e

Please sign in to comment.