only spread props if its spreadable

WordPress · Jul 13, 2018 · bc25fac · bc25fac
1 parent e7b36d8
commit bc25fac
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/components/range-control/index.js b/components/range-control/index.js
@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-import { isFinite } from 'lodash';
+import { isFinite, isEmpty } from 'lodash';
 import classnames from 'classnames';
 
 /**
@@ -32,9 +32,10 @@ function RangeControl( {
 	const id = `inspector-range-control-${ instanceId }`;
 	const onChangeValue = ( event ) => onChange( Number( event.target.value ) );
 	const initialSliderValue = isFinite( value ) ? value : initialPosition || '';
-
-	// remove any fowardedRef that may be in here.
-	const forwardedProps = Object.assign( {}, ...props );
+	// remove any forwardedRef that may be in here.
+	const forwardedProps = ! isEmpty( props ) ?
+		Object.assign( {}, ...props ) :
+		props;
 	delete( forwardedProps.forwardedRef );
 
 	return (