Dom: Add type-checking to data-transfer (#29682)

WordPress · Mar 9, 2021 · fed1fb8 · fed1fb8
1 parent ee36d98
commit fed1fb8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/packages/dom/README.md b/packages/dom/README.md
@@ -84,7 +84,7 @@ _Parameters_
 
 _Returns_
 
--   `Object[]`: An array containing all files.
+-   `File[]`: An array containing all files.
 
 <a name="getOffsetParent" href="#getOffsetParent">#</a> **getOffsetParent**
 

diff --git a/packages/dom/src/data-transfer.js b/packages/dom/src/data-transfer.js
@@ -3,10 +3,10 @@
  *
  * @param {DataTransfer} dataTransfer DataTransfer object to inspect.
  *
- * @return {Object[]} An array containing all files.
+ * @return {File[]} An array containing all files.
  */
 export function getFilesFromDataTransfer( dataTransfer ) {
-	const files = [ ...dataTransfer.files ];
+	const files = Array.from( dataTransfer.files );
 
 	Array.from( dataTransfer.items ).forEach( ( item ) => {
 		const file = item.getAsFile();

diff --git a/packages/dom/tsconfig.json b/packages/dom/tsconfig.json
@@ -0,0 +1,8 @@
+{
+	"extends": "../../tsconfig.base.json",
+	"compilerOptions": {
+		"rootDir": "src",
+		"declarationDir": "build-types"
+	},
+	"include": [ "src/data-transfer.js" ]
+}
diff --git a/tsconfig.json b/tsconfig.json
@@ -7,6 +7,7 @@
 		{ "path": "packages/block-editor" },
 		{ "path": "packages/components" },
 		{ "path": "packages/deprecated" },
+		{ "path": "packages/dom" },
 		{ "path": "packages/element" },
 		{ "path": "packages/dom-ready" },
 		{ "path": "packages/escape-html" },