Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block: Consider reducing the interface on clicking in a menu item #18315

Closed
karmatosed opened this issue Nov 6, 2019 · 11 comments
Closed
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

Currently, when you click to add an item you see this:

nav-allon

I would suggest that reducing what is shown by default to adding a link. Then when that's done the rest of the toolbar and items could appear. I know this isn't a behaviour we use everywhere right now but what we present is a lot for someone to experience.

@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Nov 6, 2019
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Nov 6, 2019
@mapk
Copy link
Contributor

mapk commented Nov 7, 2019

I'd also really like to see that input field to be larger than 2 characters by default.

@mtias mtias added the [Block] Navigation Affects the Navigation Block label Nov 7, 2019
@karmatosed
Copy link
Member Author

I don't think the input is the issue here though. For me, it's showing everything on at once. For example, reducing the toolbar back and having it just load a link interface would be better for the cognitive load. I also don't see this as an input field as it's like typing for me.

@mapk
Copy link
Contributor

mapk commented Nov 9, 2019

I don't think the input is the issue here though.

Nevertheless it's still an issue. I'm happy to create a new one if you'd like.

@karmatosed
Copy link
Member Author

@mapk absolutely, saves it being hidden in this.

@gziolo gziolo changed the title Consider reducing the interface on clicking in a menu item Navigation block: Consider reducing the interface on clicking in a menu item Dec 9, 2019
@WunderBart
Copy link
Member

Sounds good to me, @karmatosed! Also IMO, when the toolbar is visible it suggests that the block content/input is currently active. In our case (right after clicking the ⊕ button) it actually isn't - the popup input is. It becomes obvious once you start writing which will make the toolbar disappear instantly, so for me it's another reason to hide it by default. Any mouse movement brings the toolbar back, so it should not make anyone's life harder, I guess?

I'd be happy to take this one on!

@WunderBart WunderBart self-assigned this Jan 9, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 9, 2020
@WunderBart WunderBart added [Status] In Progress Tracking issues with work in progress and removed [Status] In Progress Tracking issues with work in progress labels Jan 9, 2020
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jan 20, 2020
@WunderBart WunderBart removed the [Status] In Progress Tracking issues with work in progress label Jan 23, 2020
@WunderBart
Copy link
Member

WunderBart commented Jan 23, 2020

@karmatosed I'm holding off my work (#19531, #19561) on this one as I don't believe there's a reliable way to implement this enhancement at this point (please see #19531 (comment) and #19561 (comment)). Let's get back to it once #19344 is in.

@WunderBart WunderBart removed their assignment Jan 23, 2020
@mtias
Copy link
Member

mtias commented Mar 10, 2020

@WunderBart I'd like to try the "absorb child block toolbar in the parent" setting for this one.

@tellthemachines
Copy link
Contributor

@WunderBart I'd like to try the "absorb child block toolbar in the parent" setting for this one.

@mtias could you elaborate on this approach, or point us to where it was discussed?

I'm wondering if it still makes sense to have this issue as specific to the Navigation work, given the comments here and here point to this requiring a solution consistent between all blocks.

@mtias
Copy link
Member

mtias commented Mar 23, 2020

@tellthemachines this work: #18440

And the __experimentalCaptureToolbars API.

@tellthemachines tellthemachines self-assigned this Mar 23, 2020
@getdave
Copy link
Contributor

getdave commented Apr 18, 2020

Glad the __experimentalCaptureToolbars got used :)

@draganescu
Copy link
Contributor

It looks like #18440 closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants