Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing multiple times ENTER fast throws errors or results in strange behaviour #2121

Closed
ellatrix opened this issue Aug 1, 2017 · 3 comments
Assignees
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended

Comments

@ellatrix
Copy link
Member

ellatrix commented Aug 1, 2017

Some things I noticed since #1989:

  • After a pressing enter fast for a while, it stops creating new blocks.
  • Sometimes it adds a line break in front of the block's content (also fast).
  • Sometimes it throws this error:
Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>.

Related: #2112

@ellatrix ellatrix self-assigned this Aug 1, 2017
@hedgefield
Copy link

I don't seem to be able to reproduce the first point (how long would you say is "a while"?), but I do see the line breaks appearing sometimes - basically as if you pressed shift+enter in between enters.

Also, when backspacing all those new blocks, it seems the linebreaks 'travel up' too, combining into one block with multiple linebreaks along the way (or appending it to an existing block with text in it). It's like the way drops of water form a bigger puddle when they come in contact with each other, is the only way I can describe it.

@mtias mtias added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended labels Aug 2, 2017
@moorscode
Copy link
Contributor

Holding the enter key will reproduce this for me as well.

@ellatrix
Copy link
Member Author

ellatrix commented Aug 8, 2017

Should be fixed by ab44b9b and 9784041.

@ellatrix ellatrix closed this as completed Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants