-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split paragraphs immediately on ENTER #1989
Conversation
Nice. I think this approach makes a lot more sense for enter behavior. |
Not sure why the tests failed... |
Is there any way to force another run? |
@iseulde weird, I used to be able to restart a job. I can't do it anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I really like this behaviour 👍
Same. I bet @pento broke it |
@youknowriad, @nylen: Could you try visiting your respective Travis CI profile pages, and clicking the "Sync account" button? I had to do the same, it was fine after that. |
I see the "restart job" button again without doing anything 🤔 |
Same, seems fine now. |
@m Sorry about the change! I'm really fine with it either way... |
FWIW this is the correct handling of Enter keypresses. Enter alone should always generate a new paragraph in HTML. Shift+Enter generates a line break. This is a universal standard across all word processing applications which is what WP tries to emulate with a WYSIWYG editor. |
@m Can you elaborate on the reaction? This was a major topic for an editor office hours conversation, during which we were hard-pressed to find use cases for when a single line break would be the desired behavior. https://wordpress.slack.com/archives/C02QB2JS7/p1500483704729747 While creating a new editor gives us some flexibility to establish new patterns, if the widespread convention across other editors is to split paragraphs on the single enter press, won't new users arrive with this expectation and find the disjunction to be disruptive? |
This PR changes the behaviour of the text/paragraph block. Now pressing ENTER will immediately split the block instead of allowing one line break inside the paragraph. SHIFT+ENTER will now create a line break instead of splitting the block immediately.