Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split paragraphs immediately on ENTER #1989

Merged
merged 2 commits into from
Jul 24, 2017
Merged

Split paragraphs immediately on ENTER #1989

merged 2 commits into from
Jul 24, 2017

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Jul 24, 2017

This PR changes the behaviour of the text/paragraph block. Now pressing ENTER will immediately split the block instead of allowing one line break inside the paragraph. SHIFT+ENTER will now create a line break instead of splitting the block immediately.

@spocke
Copy link

spocke commented Jul 24, 2017

Nice. I think this approach makes a lot more sense for enter behavior.

@ellatrix ellatrix requested review from youknowriad and mtias July 24, 2017 15:07
@ellatrix ellatrix self-assigned this Jul 24, 2017
@ellatrix
Copy link
Member Author

Not sure why the tests failed...

@ellatrix
Copy link
Member Author

Is there any way to force another run?

@youknowriad
Copy link
Contributor

@iseulde weird, I used to be able to restart a job. I can't do it anymore

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I really like this behaviour 👍

@mtias mtias added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Jul 24, 2017
@ellatrix ellatrix merged commit de6697d into master Jul 24, 2017
@ellatrix ellatrix deleted the try/single-enter branch July 24, 2017 20:55
@nylen
Copy link
Member

nylen commented Jul 24, 2017

weird, I used to be able to restart a job. I can't do it anymore

Same. I bet @pento broke it

@pento
Copy link
Member

pento commented Jul 25, 2017

@youknowriad, @nylen: Could you try visiting your respective Travis CI profile pages, and clicking the "Sync account" button? I had to do the same, it was fine after that.

@youknowriad
Copy link
Contributor

I see the "restart job" button again without doing anything 🤔

@nylen
Copy link
Member

nylen commented Jul 25, 2017

I see the "restart job" button again without doing anything 🤔

Same, seems fine now.

@ellatrix
Copy link
Member Author

ellatrix commented Aug 1, 2017

@m Sorry about the change! I'm really fine with it either way...

@mor10
Copy link
Contributor

mor10 commented Aug 1, 2017

FWIW this is the correct handling of Enter keypresses. Enter alone should always generate a new paragraph in HTML. Shift+Enter generates a line break. This is a universal standard across all word processing applications which is what WP tries to emulate with a WYSIWYG editor.

@aduth
Copy link
Member

aduth commented Aug 1, 2017

@m Can you elaborate on the reaction? This was a major topic for an editor office hours conversation, during which we were hard-pressed to find use cases for when a single line break would be the desired behavior.

https://wordpress.slack.com/archives/C02QB2JS7/p1500483704729747

While creating a new editor gives us some flexibility to establish new patterns, if the widespread convention across other editors is to split paragraphs on the single enter press, won't new users arrive with this expectation and find the disjunction to be disruptive?

@nylen nylen mentioned this pull request Aug 3, 2017
Tug pushed a commit that referenced this pull request Mar 19, 2020
#1989)

* Revert "Merge pull request #1842 from wordpress-mobile/issue/1829_soft-keyboard-landscape"

This reverts commit 5041096, reversing
changes made to ddb8b3f.

* Remove release note for reverted landscape mode change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants