Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to test the plugin: GH Page, separate site, or both? #655

Closed
jasmussen opened this issue May 4, 2017 · 18 comments
Closed
Labels
[Priority] High Used to indicate top priority items that need quick attention
Milestone

Comments

@jasmussen
Copy link
Contributor

jasmussen commented May 4, 2017

In order to facilitate user tests, we need an easy way to test the plugin, so @karmatosed and others run tests. Two ideas have been suggested:

GH Page:

We archive the prototypes (move to separate repo? archive elsewhere?) and run the editor, with a fake wp-admin around it.

Separate site:

@j-falk has an excellent option for testing in the wp-admin context: #655 (comment)

@jasmussen jasmussen added the [Type] Developer Documentation Documentation for developers label May 4, 2017
@jasmussen jasmussen self-assigned this May 4, 2017
@mtias mtias added User Testing and removed [Type] Developer Documentation Documentation for developers labels May 4, 2017
@aduth
Copy link
Member

aduth commented May 4, 2017

It'd require more work, but I think it would be nice to set up a version allowing public access without needing login credentials (without any save support). This could serve to hold us accountable to ensuring the editor is portable and not tied to any specific context.

Related:

@youknowriad
Copy link
Contributor

Could we use this http://poopy.life/ for a quick and easy WP site?

@j-falk
Copy link
Contributor

j-falk commented May 7, 2017

I thought about this just earlier today and found this issue, great! I decided to try an approach for this and have setup a website that could be used for testing at:

https://testgutenberg.wpkonsulterna.se/

also created this shortlink that can be used to simplify sharing:

http://bit.ly/test-gutenberg

I have no problem mapping it towards another domain if that is preferred.

The website is a standard WordPress install setup which is using the plugin Autologin Links by Paul Konstantin Gerke (https://wordpress.org/plugins/autologin-links/) to provide the possibility to login as a WordPress user only using a generated login token.

You are being logged in as a already created user who have the role Author and are being sent to the Gutenberg page which have a pre-generated post which you can start edit and save as a draft.

I have 2 thoughts though:

  • Right now the Gutenberg Plugin requires a WordPress user to have the capability manage_options to use the editor. It is not very nice to have to give that capability to a temporary user on a website. Wouldn't it make more sense to either use the capability "edit_posts" or create a custom capability if we want it to be even more flexible?

  • How could we make sure to keep the plugin updated to the latest version? Will the plugin be published on .org or should we setup a custom deployment script somehow?

@jasmussen
Copy link
Contributor Author

This seems to work great @j-falk! Thanks so much for setting this up!

Right now the Gutenberg Plugin requires a WordPress user to have the capability manage_options to use the editor. It is not very nice to have to give that capability to a temporary user on a website. Wouldn't it make more sense to either use the capability "edit_posts" or create a custom capability if we want it to be even more flexible?

@youknowriad do you know if we can do something here?

How could we make sure to keep the plugin updated to the latest version? Will the plugin be published on .org or should we setup a custom deployment script somehow?

I think for the near future we'll probably have to do it manually. But we can probably keep updates to the tagged releases, which we plan to start doing sometime this week.

@ellatrix
Copy link
Member

ellatrix commented May 8, 2017

Can't we just initialise the editor on https://wordpress.github.io/gutenberg/?

@ellatrix
Copy link
Member

ellatrix commented May 8, 2017

I guess this goes back to @aduth's comment

This could serve to hold us accountable to ensuring the editor is portable and not tied to any specific context.

@jasmussen
Copy link
Contributor Author

Can't we just initialise the editor on https://wordpress.github.io/gutenberg/?

This would show without the admin, right? Since we're actually able to show it in admin context, I think it'd be good to.

@ellatrix
Copy link
Member

ellatrix commented May 8, 2017

Yeah, it would. I'd argue that if you want to see it in context, install the plugin. I'm not sure we want to user test the context? I also like the idea that the editor could be used stand alone (e.g. as a React component).

@jasmussen
Copy link
Contributor Author

I'm not sure we want to user test the context?

I'm not a testing expert, but I feel like seeing the new editor in context of actual WordPress makes it "real" in a way it doesn't without it. I would guess this would affect test results.

I also like the idea that the editor could be used stand alone (e.g. as a React component).

I like that too — and your idea isn't bad. Just not sure it's the best for usertests.

@youknowriad
Copy link
Contributor

Wouldn't it make more sense to either use the capability "edit_posts" or create a custom capability if we want it to be even more flexible?

Yes, "edit_posts" seems more "logic" to me. Easy change, I wonder why it's "manage_options" in the first place.

@jasmussen jasmussen added this to the May Week 2 milestone May 10, 2017
@jasmussen
Copy link
Contributor Author

Let's make the edit_posts change and embrace @j-falk gracious setup of a testing site for now.

@jasmussen jasmussen added the [Priority] High Used to indicate top priority items that need quick attention label May 10, 2017
@jasmussen jasmussen removed their assignment May 10, 2017
@jasmussen
Copy link
Contributor Author

Closing this as fixed, since the edit_posts change has been merged. @j-falk do you have all you need?

@j-falk
Copy link
Contributor

j-falk commented May 13, 2017

I have all I need, I just uploaded the latest version to the site and I guess I can do it manually like this when there are new versions. How often should I update the plugin you think? Once a week?

@jasmussen
Copy link
Contributor Author

Reopening for discussing in light of new ideas.

@jasmussen
Copy link
Contributor Author

There has been some suggestions that we remove the old prototypes, and instead add a built version of the editor running there. This does not necessarily preclude others from hosting it in wp-admin, and the approach is not yet fully fleshed out, hence the reopening.

@jasmussen jasmussen changed the title Create separate site for usertesting the plugin Figure out how to test the plugin: GH Page, separate site, or both? May 17, 2017
@jasmussen jasmussen modified the milestones: May Week 3 (Alpha), Beta May 22, 2017
@ellatrix
Copy link
Member

Would be cool if https://wordpress.github.io/gutenberg/ has the editor on the whole page.

@jasmussen
Copy link
Contributor Author

Seems like we might want to close this in favor of #953?

@jasmussen jasmussen modified the milestones: May 29 to Jun 2, Beta Jun 5, 2017
@jasmussen
Copy link
Contributor Author

Closing in favor of #953.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
Development

No branches or pull requests

6 participants