Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block type: add support link #11330

Closed
wants to merge 1 commit into from
Closed

Block type: add support link #11330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/editor/src/components/block-inspector/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { isEmpty } from 'lodash';
*/
import { __ } from '@wordpress/i18n';
import { getBlockType, getUnregisteredTypeHandlerName } from '@wordpress/blocks';
import { PanelBody } from '@wordpress/components';
import { ExternalLink, PanelBody } from '@wordpress/components';
import { withSelect } from '@wordpress/data';
import { Fragment } from '@wordpress/element';

Expand Down Expand Up @@ -37,13 +37,30 @@ const BlockInspector = ( { selectedBlock, blockType, count } ) => {
return <span className="editor-block-inspector__no-blocks">{ __( 'No block selected.' ) }</span>;
}

const hasSupportLink = blockType.support && blockType.support.url && blockType.support.label;

return (
<Fragment>
<div className="editor-block-inspector__card">
<BlockIcon icon={ blockType.icon } showColors />
<div className="editor-block-inspector__card-content">
<div className="editor-block-inspector__card-title">{ blockType.title }</div>
<div className="editor-block-inspector__card-description">{ blockType.description }</div>
{ hasSupportLink && (
<div className="editor-block-inspector__card-support">
{
blockType.support.external ? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what makes a support link "external"? Is it based on the origin/hostname of the URL, and if so, is that not something we should programmatically determine on behalf of the block developer, than to impose on them?

<ExternalLink href={ blockType.support.url }>
{ blockType.support.label }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prolly need to cast this as a string to be on the safe side.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prolly need to cast this as a string to be on the safe side.

Did you still intend to make this change?

</ExternalLink>
) : (
<a href={ blockType.support.url }>
{ blockType.support.label }
</a>
)
}
</div>
) }
</div>
</div>
{ !! blockType.styles && (
Expand Down
6 changes: 5 additions & 1 deletion packages/editor/src/components/block-inspector/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,15 @@
font-size: $default-font-size;
}

.editor-block-inspector__card-support {
font-size: $default-font-size;
margin-top: $panel-padding;
}

.editor-block-inspector__card .editor-block-icon {
margin-left: -2px;
margin-right: 10px;
padding: 0 3px;
width: $icon-button-size;
height: $icon-button-size-small;
}