Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .md only commit check in travis config #12069

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

earnjam
Copy link
Contributor

@earnjam earnjam commented Nov 19, 2018

#10843 caused some failing tests to make it into master for the same reason the phpcs issue came through last week (See #11829). Seems certain rebases are throwing off the .md only file check and terminating the job early. I can’t figure out why certain rebases on PRs are causing issues but not others.

This was from the last run of #10843:

fatal: Invalid symmetric difference expression 4dcf338ba603f47bf6027a764ab0b0d389e81700...21c94151d26e53234703df2f5b47b050ec801ad4

This PR strips out the .md check portion for now until we can get it sorted.
https://github.com/WordPress/gutenberg/blob/master/.travis.yml#L22-L26

Docs only change builds taking longer is an acceptable problem if it means we don’t keep getting test failures in master

@earnjam earnjam added the [Type] Build Tooling Issues or PRs related to build tooling label Nov 19, 2018
@gziolo gziolo requested a review from a team November 20, 2018 13:27
@gziolo gziolo added this to the 4.6 milestone Nov 20, 2018
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me; I would like to know why this isn't working but for now I'm happy to just have it fixed.

@tofumatt tofumatt merged commit 0000e34 into master Nov 21, 2018
@tofumatt tofumatt deleted the remove-md-only-commit-check branch November 21, 2018 11:03
@gziolo gziolo modified the milestones: 4.6, 4.7 Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants