Fix: Unregistering a block type causes blocks that convert to it to break the editor #12192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
tofumatt
approved these changes
Nov 21, 2018
jorgefilipecosta
deleted the
fix/removing-a-block-type-causes-blocks-that-convert-to-it-to-break-the-editor
branch
|
Thank you for your review @tofumatt, I'm planning to create an end to end test covering this case, it should be available soon. |
jorgefilipecosta
added a commit
that referenced
this pull request
Nov 27, 2018
This commit adds tests that make sure the block switcher works correctly even when some blocks are removed. This test changes should catch the bug fixed in #12192.
mtias
added
the
[Feature] Block Transforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a block was registered, if we added another block that transformed to it and went to the block switcher the editor may crash.
Fixes: #12001
How has this been tested?
I added a list block.
I remove the quote block:
wp.blocks.unregisterBlockType( 'core/quote' );.I went to the switcher of the quote block, I see the application did crash and the transform to paragraph was available.
I started again; I added a list block; I opened the block switcher; I checked quote and paragraph are available as transforms; I opened the console with the switcher opened, I remove the quote block:
wp.blocks.unregisterBlockType( 'core/quote' );and I verified the quote block transform disappeared.