Editor: Apply IE11 input fix only when mounting TinyMCE #12335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #12234 (comment)
This pull request seeks to resolve an error which will occur when unmounting an instance of the RichText component in IE11. As of #12234, the
ref
callback handler was not accounting for thenull
value being passed during unmounting of the component, thus resulting in errors when subsequent logic would attempt to reference properties as if it were an DOM node.https://reactjs.org/docs/refs-and-the-dom.html#callback-refs
Testing instructions:
In Internet Explorer 11 and your preferred browser, ensure that no errors are logged when removing a paragraph block: