Fix: Upload permissions error on end 2 end inline tokens test #12459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
force-pushed
the
try/fix-end-2-end-inline-token-test
branch
12 times, most recently
from
b6354f5 to
2982385
Compare
jorgefilipecosta
force-pushed
the
try/fix-end-2-end-inline-token-test
branch
from
2982385 to
064e7e2
Compare
jorgefilipecosta
changed the title
jorgefilipecosta
changed the title
gziolo
approved these changes
Dec 4, 2018
gziolo
added
the
[Type] Automated Testing
tofumatt
approved these changes
Dec 4, 2018
|
Merging this as it just changes scripts and un-skips an end to end test which may be useful in catching future regressions. |
jorgefilipecosta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
adding-inline-tokens.test.jstest was failing on travis, instead of an image upload being successfull we got an error reporting that no permissions exist.This PR uses 2 commands on the docker container to do the following actions:
Create an uploads folder inside wp-content.
Change the folder permissions to 766.
766 was choose because according to the hierarchy we should follow when trying to fix permission problems available in https://codex.wordpress.org/Changing_File_Permissions is the most adequate value. The value bellow it (765) does not work.
How has this been tested?
I checked the end to end tests execute with success on our CI environment more specifically the test/e2e/specs/adding-inline-tokens.test.js test case.