Polish controls, floats, switches and headings #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move thecog and trash above the image in full wide. Let's see how it works.
youknowriad
approved these changes
Jun 23, 2017
|
I waffled on the subscript size, but I feel like this is worth going with for a bit. We can always adjust it later if in a week or so we find it too big. I'm also excited about the prospect of #1383, reducing the cognitive load. |
|
Just a FYI about the the On/Off toggle movement - The changes made will only apply to English, and not for the translated versions of those strings. To be fair, I cannot think of a way in CSS where you can set the min-width to be the value of the longest string (Without using some hacky JS to calculate the highest value). |
|
Solid point. Perhaps we can move the hint label to the left of the switch, when the switch is right aligned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of issues.
It fixes floats:
It fixes an issue with full wide:
It fixes a pixel jog that happened on On/Off switches due to "On" being a shorter word than "Off".
It also improves heading icons. I finally feel like they're in a good place: