Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with top bar menu having unique ARIA roles (2) #14525

Closed
wants to merge 9 commits into from
Closed

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Mar 20, 2019

Description

Opened in place of #13059. Continues work started by @Firestorm980.

Closes #12505. Adds role options to menus so that the items within the main more menu can now be groups within the menu. Should fix issues with keyboard navigation as well as roles. The menu options/props default to what they used to be, so if it isn't specified and these menus are used elsewhere, it should fallback to the old functionality.

How has this been tested?

  • Manual keyboard navigation testing in the admin with VoiceOver.
  • Ran test-e2e within Gutenberg docker.

Types of changes

  • Updates menu group component to have a default role, label, and keyboard event control
  • Changes menus used in the top nav to use group instead of menu and wraps within a parent menu
  • Changes menus used in the top nav to let the parent menu handle overall keyboard event navigation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@gziolo gziolo added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Mar 20, 2019
@gziolo gziolo changed the title Pr/13059 Fix issue with top bar menu having unique ARIA roles (2) Mar 20, 2019
@gziolo
Copy link
Member Author

gziolo commented Mar 25, 2019

Closing this one as #13059 got updated. Props to @Firestorm980 🎉

@gziolo gziolo closed this Mar 25, 2019
@gziolo gziolo deleted the pr/13059 branch March 25, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The top bar More Menu should be a unique ARIA menu
2 participants