Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build, invalid whitespace #15615

Closed
wants to merge 2 commits into from
Closed

Fix build, invalid whitespace #15615

wants to merge 2 commits into from

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented May 13, 2019

Description

I introduced a whitespace conflict with build artifact from my change #15612

This fixes the issue, I'll check with @nosolosw for updating test, it looked green on my PR.

Types of changes

Documentation, whitespace

@mkaz
Copy link
Member Author

mkaz commented May 13, 2019

A second run and the whitespace was reversed, after running npm run docs:build
I think the build error is unrelated to my change.

@mkaz mkaz closed this May 13, 2019
@mkaz mkaz deleted the docs/fix-build/whitespace branch May 13, 2019 23:15
@talldan
Copy link
Contributor

talldan commented May 14, 2019

I've also seen this on another PR, these commits:

  • 44bc955 (whitespace changed)
  • bde0e03 (whitespace reverted)

At the time I thought it was committed by error (keyboard mashing), but I think it might've originated from the git hook.

@oandregal
Copy link
Member

I see that the changes always happen in packages/core-data/README.md 🤔 I'm taking a look into that.

@oandregal
Copy link
Member

#15626 is probably related.

@oandregal
Copy link
Member

@mkaz @talldan #15679 fixes the issue. It was more involved than I expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants