Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ESNext examples to format API tutorial (page 2) #16803

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Added ESNext examples to format API tutorial (page 2) #16803

merged 2 commits into from
Aug 15, 2019

Conversation

bfintal
Copy link
Contributor

@bfintal bfintal commented Jul 30, 2019

Added Format API ESNext examples

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Jul 30, 2019
@gziolo gziolo changed the title Added ESNext examples Added ESNext examples to format API tutorial (page 3) Jul 30, 2019
@gziolo gziolo changed the title Added ESNext examples to format API tutorial (page 3) Added ESNext examples to format API tutorial (page 2) Jul 30, 2019
mkaz
mkaz requested changes Aug 6, 2019
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as your page 3 review, can you update the RichTextToolbarButton to use wp.blockEditor in ES5 example, and include the missing {% end %} for the codetabs section.

👍

@bfintal
Copy link
Contributor Author

bfintal commented Aug 15, 2019

@mkaz Added the changes :)

mkaz
mkaz approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates 👍

@mkaz mkaz merged commit 0f3c147 into WordPress:master Aug 15, 2019
@bfintal bfintal deleted the patch-1 branch August 16, 2019 00:44
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@bfintal @gziolo
Added ESNext examples to format API tutorial (page 2) (#16803)
fd8408c 
* Added ESNext examples

* Added missing end tags
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@bfintal @gziolo
Added ESNext examples to format API tutorial (page 2) (#16803)
aa82927 
* Added ESNext examples

* Added missing end tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfintal @mkaz @gziolo