Remove: Child blocks from block manager #17128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
force-pushed
the
update/disable-child-blocks-from-block-manager
branch
from
c39fcac to
3e49159
Compare
brentswisher
approved these changes
Sep 5, 2019
jorgefilipecosta
deleted the
update/disable-child-blocks-from-block-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: #15121
This PR makes sure child blocks don't appear in the block manager, so we are consistent with the inserter currently they don't appear on the inserter by default.
How has this been tested?
I pasted the following code block in the browser console: https://gist.github.com/jorgefilipecosta/60a0bf242e8c7c18805618558268315d
I verified the Test Child block was not available in the block manager (on master it is).