Add max-width to pinned icon SVGs.

[jasmussen]

Mitigates #17719.

It's not perfect, because those drop-it icons aren't designed with any clearance. But at least it's a last-defence failsafe.

In #17719 (comment) we figured out the cause of the regression. This regression should be fixed separately. But this PR could serve as an addition to that.

[gziolo]

It looks like #17752 attempts to resolve the same issue differently.

[jasmussen]

Yes indeed! As noted, there needs to be a proper fix, which is what #17752 appears to be, and this PR is then a fallback. Right now we do not provide ANY boundaries to SVGs, so plugins can throw in a giant SVG and it will happen again. This PR doesn't look at what dimensions the icon comes with, it simply applies maximum dimensions.

This one is not urgent if the other has been merged, and might even need feedback: should plugin developers be able to provide icons bigger than 24x24? (it doesn't fit) But I think it'd be good to have some fallback.

[gziolo]

So the question is whether we should enforce those limits more broadly? There are more places where we would benefit from it:

• dropdown menu
• block toolbar
• header in general

[jasmussen]

I used to be very strict about this, by my personal opinion has changed a little bit.

I think it's important that the icon is no bigger than 24x24.

I think it's okay for an icon to have color, I used to think we should enforce all gray.

Ideally it's also ONLY 24x24, designed for it, and using only a single color. But we can't enforce this bit.

But all of that is maybe a separate discussion.

[gziolo]

Fine with me as is :)

[etoledom]

Since #17752 was merged, do we still need the changes on this PR?

[jasmussen]

@etoledom yes as noted in #17722 (comment), I believe there needs to be an additional fallback to catch situations where a plugin developer adds a big SVG icon and does not provide proper width/height to go with that.