Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Button active status in the mobile apps #17905

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Fix Button active status in the mobile apps #17905

merged 1 commit into from
Oct 14, 2019

Conversation

koke
Copy link
Contributor

@koke koke commented Oct 11, 2019 •
edited
Loading

Description

In #17676, the active prop in Icon/SVG got renamed to __unstableActive, but Button was still using the old name.

How has this been tested?

On WordPress for iOS:

  1. Added a new post
  2. Wrote some text
  3. Selected "Bold" in the formatting toolbar

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1440

Screenshots

button-active

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@koke
Fix Button active status
960a208 
In #17676, the `active` prop in Icon/SVG got renamed to `__unstableActive`, but
Button was still using the old name.
@koke koke added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Oct 11, 2019
@koke koke requested a review from etoledom October 11, 2019 11:37
@koke koke mentioned this pull request Oct 11, 2019
Merged
1 task
etoledom
etoledom approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!
Thank you @koke for fixing this 🙏

@koke koke merged commit d8bb752 into master Oct 14, 2019
@koke koke deleted the rnmobile/fix-button-active branch October 14, 2019 10:21
@youknowriad youknowriad added this to the Gutenberg 6.7 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 6.7
Development

Successfully merging this pull request may close these issues.
3 participants
@koke @etoledom @youknowriad