Popover: remove buffer options #19283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
chrisvanpatten,
daniloercoli,
etoledom,
jorgefilipecosta,
SergioEstevao,
talldan and
youknowriad
as code owners
ellatrix
force-pushed
the
remove/popover-buffer
branch
from
26e83cb to
01320e7
Compare
youknowriad
reviewed
Dec 20, 2019
| @@ -55,6 +55,7 @@ figcaption.block-editor-rich-text__editable [data-rich-text-placeholder]::before | |||
|
|
|||
| .components-popover__content { | |||
| min-width: auto; | |||
| margin-bottom: 6px; | |||
There was a problem hiding this comment.
while this seem simpler, from a user's perspective, it's less obvious. I wonder if keeping the prop and make it work by adding a margin could be the best of both worlds. No urgency though, just a thought in case this becomes a common pattern.
There was a problem hiding this comment.
From my experience with #18779, it does seem easier at first to have an option like this, but this option is way less flexible than CSS. In CSS you can adjust it based on classes etc. It's also something that's clearly styling and should ideally be done in CSS if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These options were added in #17867, but I realised recently that we could just use a margin. 🙈
These options were not documented and not part of any WordPress release, so they are safe to remove.
How has this been tested?
Check the inline toolbar position for the image block. There should be some space between the caption text and the toolbar.
Screenshots
Types of changes
Checklist: