[RNMobile][Monorepo] Update react-native-* packages from gutenberg-mobile #20533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tug
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
daniloercoli,
dmsnell,
ellatrix,
etoledom,
gziolo,
jorgefilipecosta,
karmatosed,
mapk,
mkaz,
mmtr,
nerrad,
noisysocks,
oandregal,
ntwb,
SergioEstevao,
Soean,
swissspidy,
talldan,
TimothyBJacobs and
youknowriad
as code owners
Co-authored-by: Marcus Kazmierczak <[email protected]>
* Project Management Automation: Add TypeScript type-checking * Project Management Automation: Remove unused typedefs
* Add period at the end of sentence. * Add translator comment
* Text Component * Rename * Lint fixes
…20985) * Add isFileURL method and use it on all native media upload checks. * Check if url is defined. * Add test for undefined and fix lint error for isFileURL * Replace isFileURL method for getProcotol == 'file' mettod
|
@dratwas thanks for reviewing! I might actually update once more since we're at it (also gutenberg-mobile changes are out of sync with gutenberg here and it causes problem when we try to run the app) @gziolo Just wanted you to know about it :) |
|
@gziolo Actually we'll need an admin to merge without squashing. Let's ping once it's ready |
…/monorepo-update-gb-mobile-rn
…pdate-gb-mobile-rn
|
Size Change: +30.2 kB (3%) Total Size: 856 kB
ℹ️ View Unchanged
|
|
@dratwas it's ready for another pass :) Btw, you can try to actually build the dev bundle by requesting: |
ceyhun
approved these changes
Mar 23, 2020
It's disabled for me at the moment. @youknowriad has superpowers to change that :) |
|
@hypest I think you have the superpowers as well, could you try to do it? For reference, the reason we need this is because until we haven’t made the switch to use |
|
Merging with "Merge commit" option set to true 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR's goal is to bring the latest changes from gutenberg-mobile to the monorepo branch.
Thus, it also gets gutenberg
masterrecent changes in are the 2 repo needs to be in sync.Most commits are from the gutenberg-mobile repo, the ones that are not are merge commits (from gb-mobile develop or gb master)
Testing Instructions
Try running the following commands:
npm run native testnpm run test-unit:nativenpm run native start:resetthencurl --silent --output /dev/null "http://localhost:8081/index.bundle?platform=android&dev=true&minify=false"to generate a bundle for androidTypes of changes
Port of commits
Checklist: