[RNMobile][Monorepo] Update from master and fix web e2e tests #21966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -14.3 kB (1%) Total Size: 828 kB
ℹ️ View Unchanged
|
[UI tests] Cover additional blocks with UI tests
Release v1.27.0
…uggestions (#21873) * Configure the navigation editor with correct __experimentalFetchLinkSuggestions * Move __experimentalFetchLinkSuggestions from block-editor to editor * Update package-lock.json * Update package-lock.json * Copy fetchLinkSuggestions over to edit-navigation * Update formatting in package.json * Update package-lock.json * Update package-lock.json
* Add a method for publishing patches to the lerna scripts. * Spelling is hard. * Let's swap to to help with the major.minor.patch semver structure. * Add a bit to the docs.
* Fix props in example code for Edit Post module * Fix props in JSDoc for Edit Post module
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
cameronvoell
added
the
Mobile App - i.e. Android or iOS
No changes in this commit, since the release branch had the changes already cherry-picked. This commit is for book-keeping purposes only.
[UI tests] Schedule runs for full UI tests suite
Merge master back to develop for v1.27.0
* Reinitialize the iframe after the parent block is moved around * Apply eslint
Co-Authored-By: Drapich Piotr <[email protected]>
|
Works great locally! I think it would be good to integrate them with Gutenberg CI tests and make sure they run correctly on saucelabs now |
* revert bad merge * removed author storage we also set post author on change from the block itself. * linting * use sizes to label avatar size this aloows us to use the sizes as the API serves them * adds some review suggestions props @ockham * removes null coalescing operator
* Implement native Cover overlay color settings component * Add overlay color settings to native Cover block * Remove unnecessary attributes spread from setOverlayAttribute * Trigger travis
|
Hi @Tug 👋 😃 Just a heads up, since I noticed a few commits that change the screen coordinates for the Android emulator: the copy-paste UI tests currently rely on tapping a screen offset from the carret position since the UI to copy and paste is part of the OS and not the app, and thus cannot be clicked via the usual XPath mechanism. In case you see failures for these E2E tests, it may be possible that these offsets need to be tweaked for different screen sizes, or a change in the API level. If these tests are not failing (or are failing for other reasons), no need to alter anything, I just wanted to point out there is the potential for fragility there. |
* menu locations page setup * adds saving location, broken for now * adds UI panels * fixes incorrect labeling * await for each location assignment * refactors according to review main change is elliminating some useless falsey checks * sends one request per menuId * properly awaits for saveMenu * updates the satate of the locations form with edits * adds code tweaks according to code review * reafactored for better code readability * adds a custom hook for location manipulation * refactoring according to code review * encapsulates more of the locations logic in the locations hook * more variable name refactoring * refactoring based on review * refactored to remove state mutation and save empty locations properly
* Submenu nesting and saving new nested items. * Address review feedback * Save parent items before nested items * Save sub-items of new items * Remove logging in error. * Array manipulation improvement * Address review feedback * Fix PHP lint errors
|
Hi @mkevins! Indeed I tried to reproduce the saucelab env by tweaking the sceen size but I was careful not to chang the coordinates offsets dw there ;) |
Tug
changed the title
…#22235) * Create Block: Use glob to find all template files * Create block: Refactor template handling * Move output files templates to getBlockTemplate * Add CHANGELOG entry * Apply suggestions from code review Co-authored-by: Andrew Duthie <[email protected]> Co-authored-by: Andrew Duthie <[email protected]>
…rg-mobile-no-squash-E2E-TESTS
Tug
changed the base branch from
feat/import-gutenberg-mobile-no-squash
to
master
Tug
changed the base branch from
master
to
feat/import-gutenberg-mobile-no-squash
Tug
changed the base branch from
feat/import-gutenberg-mobile-no-squash
to
master
Tug
changed the base branch from
master
to
feat/import-gutenberg-mobile-no-squash
…squash' into feat/import-gutenberg-mobile-no-squash-E2E-TESTS
Tug
force-pushed
the
feat/import-gutenberg-mobile-no-squash-E2E-TESTS
branch
from
9cc1523 to
2bc61da
Compare
ceyhun
approved these changes
May 14, 2020
|
Will merge this now with "Merge commit" GitHub option turned on, to preserve the commit history. Will remove the option right afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the Monorepo effort
Description
This PR aims to get web e2e tests working on the monore repo feature branch (feat/import-gutenberg-mobile-no-squash). It does so by updating from gutenberg
masterand gutenberg-mobiledevelop.How has this been tested?
This enables back travis CI on the
feat/import-gutenberg-mobile-no-squashbranch.npm run native ios/androidandnpm run native startTypes of changes
Checklist: