-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try adding a 'spotlight mode' type effect when template part or child is selected. #25656
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
627dcf3
apply mode from blocklist + css
Addison-Stavlo 6181fd4
added class to most active template part
Addison-Stavlo 1f117bd
css rules to support nested/active template parts
Addison-Stavlo 536a55b
gate template part check behind site editor experiment
Addison-Stavlo 70c56e5
rebrand/refactor to support more entity blocks if necessary
Addison-Stavlo 5bd9384
move logic to selector
Addison-Stavlo 9a620d9
change selector name and add doc comments
Addison-Stavlo f30c4a1
update tests for updated selector
Addison-Stavlo 1ef3695
add test for new selector
Addison-Stavlo 05a921e
make test state reusable for updated parents tests
Addison-Stavlo 27ea5d6
cleanup document-actions useSecondaryText to use new selector
Addison-Stavlo 83f3c69
add dependency to selector for selectionEnd
Addison-Stavlo 624b93b
remove unnecessary style selectors
Addison-Stavlo 01a91f7
make selector experimental
Addison-Stavlo 9f77800
refactor list of blocks to editor settings
Addison-Stavlo 1646269
selector return early if no names are passed
Addison-Stavlo 7a838f0
update css comment from template part to entity
Addison-Stavlo 4c8e7c5
rename the settings list to include 'entity'
Addison-Stavlo 13daf62
Merge branch 'master' into try/spotlight-mode-for-template-parts
Addison-Stavlo 3a49591
Merge branch 'master' into try/spotlight-mode-for-template-parts
Addison-Stavlo 7a1e61d
Merge branch 'master' into try/spotlight-mode-for-template-parts
Addison-Stavlo 51ecd99
Merge branch 'master' into try/spotlight-mode-for-template-parts
Addison-Stavlo 5c5dfb7
remove unused import
Addison-Stavlo 9f83900
Merge branch 'master' into try/spotlight-mode-for-template-parts
Addison-Stavlo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: should we update this to
blockNames
then? ReadingblockName.includes
threw me off at first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Im not sure tbh. The original use is a string of a single blockName and this is still supported. Since it can either be a string or an array of strings, whether we use
blockName
orblockNames
it will still read a bit funky somewhere. ( likename === blockNames
) 🤷♀️ At least the blockName.includes is nested in anif ( isArray( blockName )