-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: fix gray gap. #27187
Try: fix gray gap. #27187
Conversation
Size Change: -10 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In testing this got rid of the grey gap at the bottom, thanks @jasmussen.
Thank you, I'll let this one sit to see if the checks pass! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this if it does the trick. e2e test failures seem to be intermittent.
Fixes #27157.
e193d4c
to
d980a03
Compare
I can't get the tests to pass, I keep getting this:
|
Ah, seems to be legitimate. I'll have a look now to see if I can fix it. |
@jasmussen It seems like this is needed to expand the click redirect on an empty page:
Unfortunately I'm not able to apply it correctly. Maybe I'm missing something. Here's the problem with this PR. The click redirect div somehow needs to expand to the bottom. |
I believe #27253 addressed the same issue this PR intended to fix, but is better, so I'm closing this one! |
Fixes #27157.
Props @tellthemachines for suggested fix in #27157 (comment).
Before there was a gray gap when you scrolled down to the bottom of the page. This PR fixes that: