Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: fix gray gap. #27187

Closed
wants to merge 1 commit into from
Closed

Try: fix gray gap. #27187

wants to merge 1 commit into from

Conversation

jasmussen
Copy link
Contributor

Fixes #27157.

Props @tellthemachines for suggested fix in #27157 (comment).

Before there was a gray gap when you scrolled down to the bottom of the page. This PR fixes that:

Screenshot 2020-11-23 at 08 46 11

@jasmussen jasmussen added the [Type] Regression Related to a regression in the latest release label Nov 23, 2020
@jasmussen jasmussen self-assigned this Nov 23, 2020
@github-actions
Copy link

github-actions bot commented Nov 23, 2020

Size Change: -10 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/edit-post/style-rtl.css 6.45 kB -5 B (0%)
build/edit-post/style.css 6.43 kB -5 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.8 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 664 B 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 133 kB 0 B
build/block-editor/style-rtl.css 11.3 kB 0 B
build/block-editor/style.css 11.3 kB 0 B
build/block-library/editor-rtl.css 8.96 kB 0 B
build/block-library/editor.css 8.96 kB 0 B
build/block-library/index.js 148 kB 0 B
build/block-library/style-rtl.css 8.23 kB 0 B
build/block-library/style.css 8.23 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 172 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/compose/index.js 9.95 kB 0 B
build/core-data/index.js 14.8 kB 0 B
build/data-controls/index.js 827 B 0 B
build/data/index.js 8.8 kB 0 B
build/date/index.js 11.2 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.95 kB 0 B
build/edit-navigation/index.js 11.1 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-site/index.js 23.6 kB 0 B
build/edit-site/style-rtl.css 3.86 kB 0 B
build/edit-site/style.css 3.86 kB 0 B
build/edit-widgets/index.js 26.4 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/index.js 43.3 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.86 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.27 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keyboard-shortcuts/index.js 2.54 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.81 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/index.js 2.92 kB 0 B
build/rich-text/index.js 13.3 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.05 kB 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing this got rid of the grey gap at the bottom, thanks @jasmussen.

@jasmussen
Copy link
Contributor Author

Thank you, I'll let this one sit to see if the checks pass!

Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this if it does the trick. e2e test failures seem to be intermittent.

@jasmussen
Copy link
Contributor Author

I can't get the tests to pass, I keep getting this:

Summary of all failing tests
FAIL specs/editor/various/adding-blocks.test.js (69.864s)
  ● adding blocks › Should insert content using the placeholder and the regular inserter

    TimeoutError: waiting for selector "[data-type="core/paragraph"]" failed: timeout 30000ms exceeded

@ellatrix
Copy link
Member

Ah, seems to be legitimate. I'll have a look now to see if I can fix it.

@ellatrix
Copy link
Member

@jasmussen It seems like this is needed to expand the click redirect on an empty page:

.block-editor-writing-flow {
	display: flex;
	flex-direction: column;
}

Unfortunately I'm not able to apply it correctly. Maybe I'm missing something.

Here's the problem with this PR. The click redirect div somehow needs to expand to the bottom.

Screenshot 2020-11-24 at 21 57 39

@jasmussen
Copy link
Contributor Author

I believe #27253 addressed the same issue this PR intended to fix, but is better, so I'm closing this one!

@jasmussen jasmussen closed this Nov 25, 2020
@johnbillion johnbillion deleted the try/fix-gray-gap branch February 10, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grey gap at bottom of screen when scrolling
3 participants