Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bug form to use drop downs #34458

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Update bug form to use drop downs #34458

merged 5 commits into from
Sep 2, 2021

Conversation

annezazu
Copy link
Contributor

@annezazu annezazu commented Sep 1, 2021

Description

This is a minor change that removes the checkboxes since that causes a todo list functionality to be triggered in the UI, making it hard for contributors to keep track of what's happening.

How has this been tested?

N/A

Screenshots

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

This is a minor change that removes the checkboxes since that causes a todo list functionality to be triggered in the UI, making it hard for contributors to keep track of what's happening.
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Type] Project Management Meta-issues related to project management of Gutenberg labels Sep 1, 2021
Messed up the second dropdown item
@youknowriad
Copy link
Contributor

Any idea how this looks like in the end?

@youknowriad youknowriad requested a review from priethor September 1, 2021 16:33
Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this in a private repo, it looks like this:
image

@annezazu
Copy link
Contributor Author

annezazu commented Sep 1, 2021

Huzzah! Thank you @priethor for the review, the commit, and the screenshot :)

@priethor
Copy link
Contributor

priethor commented Sep 1, 2021

It seems a bit inconvenient to need to open the dropdown, then select the option. It's two clicks that I doubt people will do to select No.

Given there is no option to set default values to preselect No, should these fields be required instead?

Based on feedback, this updates the form to make the dropdowns required.
@annezazu
Copy link
Contributor Author

annezazu commented Sep 1, 2021

Great idea - just made the required!

@talldan talldan merged commit 89abda1 into trunk Sep 2, 2021
@talldan talldan deleted the annezazu-patch-1 branch September 2, 2021 05:55
@github-actions github-actions bot added this to the Gutenberg 11.5 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement. [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants