Columns block: Prevent reducing column count from deleting content #34893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Block] Columns
|
Size Change: +225 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
stokesman
force-pushed
the
update/columns-guard-content-deletion
branch
from
b88c6fe to
1ad6d70
Compare
7 tasks
stokesman
force-pushed
the
update/columns-guard-content-deletion
branch
from
1ad6d70 to
b8bcb4e
Compare
|
Awesome :) this is an old problem to try and solve. In the original issue the goal was to make the columns block wrap the content that would be removed on a new "row". The columns block does not have rows though. The solution here is interesting (I too like this control better than the slider) but it does not seem easy to intuit to me why the disabled options are disabled. |
|
I'd like to abstract the design from a potential solution (leave the current design in place). Perhaps storing the "deleted" columns in the current session, to be inserted when adding back a column? Shared here: #9009 (comment) |
stokesman
force-pushed
the
update/columns-guard-content-deletion
branch
from
b8bcb4e to
3965085
Compare
I’ve tried an added help message on the control for such cases so it doesn’t have to be intuited. Only took three years 😆.
I think design is the root of the issue but that said this PR doesn’t attack the root, merely tries avoiding its pitfall. If you were going off the old screen recordings I did have some extraneous design changes that are now reverted (and replaced the old screen recordings with a current one). |
|
As I mentioned on the issue, can we try to meet expectations first by making the behavior where if you go down in column count, and then back up, your content is not seemingly gone? I think we can solve this without any design changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is aimed to resolve a rather old issue #9009. It should probably be vetted UX-wise before worrying about a code-review so it's drafted for now.
The control for the column quantity is now a
ToggleGroupControlwhich has its options disabled in accord with the number of occupied columns and thereby prevents deleting content. Even without that, the new control seems like an improvement because it communicates the recommended range of columns whereas the slider is vague.Testing Instructions
…
Screenshots
columns-guard-content-deletion.mp4
Types of changes
Enhancement to close: #9009
Checklist:
*.native.jsfiles for terms that need renaming or removal).