[Block Library - Post Comment Content]: Fix block's edit function #35190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
youknowriad,
aristath,
jameskoster and
carolinan
ntsekouras
commented
Sep 28, 2021
| return ( | ||
| <div { ...useBlockProps() }> | ||
| <p className={ className }>{ content }</p> |
There was a problem hiding this comment.
Did this used to work somehow before? 🤔
The API seems to return an object from the start?
There was a problem hiding this comment.
Hi @ntsekouras, I just saw that we are working on the same issue, although it seems that you have advanced more than me 😃 😅 #35183
Did this used to work somehow before? 🤔
Wondering the same ― for me, it wasn't working. Which totally makes sense, as the object the useEntityProp hook returns comes from the REST API.
There was a problem hiding this comment.
Hey David 👋 - sorry for this... I was reviewing the post avatar PR and noticed that it was broken.
I had seen that there was activity to the issue and my PR just fixes the breakage without the rest enhancements in the issue - that's why I just mentioned it as related..
I guess we can land this PR and you handle all the other stuff (including the renaming 😄 ). What do you think?
There was a problem hiding this comment.
Yeah, no problem! I'll wait for this PR to be merged. 👍
|
Size Change: +225 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Sep 28, 2021
Mamaduka
reviewed
Sep 28, 2021
Co-authored-by: George Mamadashvili <[email protected]>
jameskoster
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #30574
I was reviewing another PR and saw that
Post Comment Contentblock was broken in editor.This PR fixes that and also has some small enhancements to the
Post Commentblock by adding a defaulttemplateand removing the extra wrapperdiv.