WIP: Explore typing on core data packages #35869
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
force-pushed
the
dmsnell/data-typing
branch
from
ada10d4 to
1222a37
Compare
dmsnell
added a commit
that referenced
this pull request
Oct 28, 2021
While working on #35869 I discovered that the module where we keep some top-level type definitions is named with the `.d.ts` suffix as if it were a manually-maintained types definition file. It's capable of being a normal TypeScript module though, and my IDE was having a bit of trouble with the `.d.ts` suffix - not because that was wrong, but I think because it was different than what the IDE expected. In this patch all we're doing is renaming the file in order to smooth this over and clean up later type-related patches that will occur to the data package. Updating `tsconfig.json` was necessary becuase of the rename so that TypeScript will appropriately find and use these types.
7 tasks
dmsnell
force-pushed
the
dmsnell/data-typing
branch
from
13d1e88 to
e2022a7
Compare
dmsnell
added a commit
that referenced
this pull request
Oct 29, 2021
While working on #35869 I discovered that the module where we keep some top-level type definitions is named with the `.d.ts` suffix as if it were a manually-maintained types definition file. It's capable of being a normal TypeScript module though, and my IDE was having a bit of trouble with the `.d.ts` suffix - not because that was wrong, but I think because it was different than what the IDE expected. In this patch all we're doing is renaming the file in order to smooth this over and clean up later type-related patches that will occur to the data package. Updating `tsconfig.json` was necessary becuase of the rename so that TypeScript will appropriately find and use these types.
dmsnell
force-pushed
the
dmsnell/data-typing
branch
from
e2022a7 to
9c4fd68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How much can we get from core data types?
I like getting stuff for "free" (in the screenie we rename the file to
.tsand the store auto-infers, something we could plausibly do for all the core packages)This is a playground-PR related to #34190
Notes
packages/data/src/types.d.ts. It might help to create separate TS files but I need to figure out how this impacts the generated types in the project. SpecificallyWPDataStoreandWPDataRegistryseem circular in a logical way..tsand this impacts module resolution. I have TypeScript working but my IDE shows an error, unable to resolve module. I would love for this resolution to work without having to stub out atsconfig.jsonfile in every package that references other packages and will need to check if this is already "resolved" in other packages.