Update navigation block entity automatic name generation and refine naming UI #36238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
|
Size Change: +336 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Nov 5, 2021
packages/block-library/src/navigation/edit/unsaved-inner-blocks.js
Outdated
Show resolved
Hide resolved
|
Looks like the widgets tests are broken in |
talldan
force-pushed
the
update/nav-block-entity-auto-naming
branch
from
4f620b1 to
fed1f23
Compare
talldan
force-pushed
the
update/nav-block-entity-auto-naming
branch
from
fed1f23 to
d30c7f3
Compare
|
It only uses the "Header Navigation" in the name if the block is added in the header. If it's moved from somewhere else, it remains just "Navigation". I'm not sure which on is better so I'm just noting it here @talldan Also, there is a bug in trunk if you insert a nav block like this directly anywhere: <!-- wp:navigation -->
<!-- wp:navigation-link /-->
<!-- wp:navigation-link /-->
<!-- wp:navigation-link /-->
<!-- /wp:navigation -->It crashes the editor. It effectively prevents the user from adding any pattern including the navigation block. The problem is gone if I comment out this effect: gutenberg/packages/block-library/src/navigation-link/edit.js Lines 423 to 430 in 098278b Let's fix it next week and not block this PR on it. |
adamziel
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #35947
Address the comment here - #36169 (comment).
Also moves the UI for menu naming and deleting UI to the 'advanced' section as often requested. I still strongly feel this isn't the right solution, and naming is important for users. I wasn't able to come up with an alternative in the limited time that lowers the prominence of the UI. Gutenberg still has limited support for ordering inspector panels. There were also no other designs put forward for this problem other than the advanced panel. 🤷
With this improvement it's less of an issue. We'll see what feedback comes in and adjust as necessary.
How has this been tested?
Alternative testing instructions:
Screenshots
(I changed the menu names slightly since this screeenshot)
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).