-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the "env" script when --wp-env or wpEnv is present. #38530
Merged
ryanwelcher
merged 7 commits into
WordPress:trunk
from
ryanwelcher:try/adding-script-when-env-is-added
Feb 4, 2022
Merged
Adding the "env" script when --wp-env or wpEnv is present. #38530
ryanwelcher
merged 7 commits into
WordPress:trunk
from
ryanwelcher:try/adding-script-when-env-is-added
Feb 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea. It brings more consistency 👍🏻
Would you mind listing it in the CHANGELOG of the package?
gziolo
reviewed
Feb 4, 2022
Co-authored-by: Greg Ziółkowski <[email protected]>
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Developer Experience
Ideas about improving block and theme developer experience
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Tool] Create Block
/packages/create-block
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #25188 (comment), when the
--wp-env
flag is passed or thewpEnv
is added to a template, there is no accompanying script added to the package. json.Testing Instructions
Test locally using:
./node_modules/.bin/wp-create-block --wp-env
to test the flag./node_modules/.bin/wp-create-block --template=@ryanwelcher/dynamic-block-template
to test a template usingwpEnv
./node_modules/.bin/wp-create-block
to ensure that no additional scripts are added.Types of changes
New feature. Adds
"env": "wp-env"
to the package.jsonChecklist:
*.native.js
files for terms that need renaming or removal).