-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove APIs deprecated on WordPress 5.4 #38564
Conversation
Size Change: -219 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
if ( ! plugin ) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a fix for wp.data.plugins.control
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modal
's isDismissable
removal LGTM 👍 Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, and good call on punting more impactful APIs 👍
There are some APIs deprecated on WP 5.4 that I didn't remove but instead set for removal on WordPress 6.2. These are more impactful than the removed ones: