Use the theme.json classes defined by the plugin in the REST controller #38663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
oandregal
changed the title
oandregal
added
the
Global Styles
bph
added
the
Needs Dev Note
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the REST controller to use the classes defined by the plugin instead of using the ones defined by WordPress.
The plugin supports WordPress 5.8 and WordPress 5.9. Both versions have the theme.json classes but use different implementations. Using the classes defined by WordPress is problematic because the endpoint defined by the plugin will behave differently depending on the WordPress version, so we should use the ones defined by the plugin.
Some examples of things that are different that could affect this endpoint: the
LATEST_SCHEMAchanges from 1 to 2, the constructor does more things in 5.9 (such as checking whether we should remove theme colors that are already defined by core or opt-in into a few defaults), the resolver looks up for child themes in 5.9.