E2E Tests: Tweak Comments block tests after migrating to Playwright #42406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5.17 kB (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
Hey @kevin940726 👋 I noticed that @ockham migrated |
kevin940726
reviewed
Jul 14, 2022
There was a problem hiding this comment.
Nice work! 👍
it's being used by at least 3 test suites in
e2e-tests, so I'm wondering if this util is actually a temporary solution
I still think the implementation is still a temporary solution, because it's going to the actual options.php page to set them, which is slow and against the best practices. If we can implement it using rest then it belongs in e2e-test-utils-playwright, but until then, putting it there now means we'll inevitably have to introduce breaking changes in the future for that util.
packages/e2e-test-utils-playwright/src/request-utils/comments.ts
Outdated
Show resolved
Hide resolved
|
Thanks, @kevin940726! I followed your latest suggestions and I think it's ready to review again. 😊 |
kevin940726
reviewed
Jul 15, 2022
packages/e2e-test-utils-playwright/src/request-utils/comments.ts
Outdated
Show resolved
Hide resolved
packages/e2e-test-utils-playwright/src/request-utils/comments.ts
Outdated
Show resolved
Hide resolved
packages/e2e-test-utils-playwright/src/request-utils/comments.ts
Outdated
Show resolved
Hide resolved
packages/e2e-test-utils-playwright/src/request-utils/comments.ts
Outdated
Show resolved
Hide resolved
kevin940726
approved these changes
Jul 15, 2022
10 tasks
|
Thanks @DAreRodz and @kevin940726! ❤️ |
Mamaduka
added
the
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of #39826. This applies some suggestions shared by @kevin940726 in that PR.
Why?
To follow Playwright's best practices (and also to get familiar with that library 😄).
How?
awaitusage withpage.locator.toHaveCountwith.toBeVisible,.toBeHidden)afterEachinstead ofafterAllResponseobject fromrequestUtils.createCommentrequestUtils.createCommentrequestUtils.getCurrentUserutilityadmin.setOptionutilityTesting Instructions
Simply running