Collapse the publish sidebar when making edits to a published post #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Feature] Document Settings
mtias
force-pushed
the
add/collapse-publish-sidebar-when-editing
branch
from
e14b6dc to
14cd3ff
Compare
mtias
force-pushed
the
add/collapse-publish-sidebar-when-editing
branch
from
14cd3ff to
618db7b
Compare
aduth
reviewed
Feb 12, 2018
|
|
||
| // Automatically collapse the publish sidebar when | ||
| // a post is published and the user makes an edit. | ||
| if ( this.props.isPublished && newProps.isDirty ) { |
There was a problem hiding this comment.
Minor: componentWillReceiveProps is slated for deprecation in favor of either static getDerivedStateFromProps or componentDidUpdate. Since this doesn't classify as a state derivation, it'd be most future-proof to include this logic in a componentDidUpdate.
aduth
approved these changes
Feb 12, 2018
|
@aduth mind checking again? |
aduth
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4976.
As described in the issue, this seeks to close the post-publish sidebar if the user makes edits to a post they just published.
It will benefit from work being done in #4955.