Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Upgrade Rememo dependency to 2.4.0 #5002

Merged
merged 2 commits into from
Feb 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions editor/store/selectors.js
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,8 @@ export const getBlock = createSelector(
innerBlocks: getBlocks( state, uid ),
};
},
( state ) => [
get( state, [ 'editor', 'present', 'blocksByUid' ] ),
( state, uid ) => [
get( state, [ 'editor', 'present', 'blocksByUid', uid ] ),
get( state, [ 'editor', 'present', 'edits', 'meta' ] ),
get( state, 'currentPost.meta' ),
]
Expand Down
1 change: 1 addition & 0 deletions lib/client-assets.php
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ function gutenberg_register_scripts_and_styles() {
gutenberg_get_script_polyfill( array(
'\'Promise\' in window' => 'promise',
'\'fetch\' in window' => 'fetch',
'\'WeakMap\' in window' => 'WeakMap',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever register WeakMap polyfill.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, whoops, I was used to my original implementation which had passed this through as a feature argument to polyfill.io . I'll see about fixing this up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this should not cause breakage for users without WeakMap support, as in later iterations of the new rememo release, it was made to be an optional enhancement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I guess we need those optimizations for WP community :D

) ),
'before'
);
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"redux-multi": "0.1.12",
"redux-optimist": "0.0.2",
"refx": "3.0.0",
"rememo": "2.3.4",
"rememo": "2.4.0",
"showdown": "1.7.4",
"simple-html-tokenizer": "0.4.1",
"tinycolor2": "1.4.1",
Expand Down