Unify animation metrics in site editor #51525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +2.53 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c1fd17b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5291959911
|
|
Thanks for sweating the details. Looking at the two tabs side by side, my main take-away is that:
Comparing the two, I actually prefer trunk, notably the fast naviator animation and the slightly slower in/out editor animation. I do think they can be tweaked — I really like the easeInOut animation in this branch, and I do think the in/out of editor animation can be slightly faster. But not quite as fast as it is in this trunk. I also think the left sidebar navigation should stay pretty fast. What do you think? |
|
Could work. Please feel free to push any ideas, this is mostly a for-fun experiment :) |
|
With just a quick look at the video... I got to say I like what I see! The animation is smooth and quick and goes straight to what is needed without any delay. It creates helpful transitions between various screens. |
|
Tried pushing some changes. Sidebar navigatio is slightly slower than before, and editor entry slightly faster. Tiny tweaks, but this feels balanced to me. Let me know what you think. |
|
Sidebar feels decent. I think the frame could be a smidge faster 🙊 |
|
Heh, I'm willing to negotiate, but one of the reasons why I think we should't make it too fast is that it's a pretty important "place-setting" animation that literally transplants you between site view and edit view. Normally I'm all-in on the "fast animation" camp, but in this case I also feel like the animation starts to be weirdly jumpy if sped up beyond 0.45, and the easing becomes almost invisible. |
|
Yes there's definitely a balance to get right. I agree it's a significant transition, and a slower animation can help communicate that. But ideally it's handled in a way that still feels snappy, so it's a question of how fast we can go while still indicating the gravity of the context change. The Mission Control shortcut in Mac OS get's this just right imo, and feels just a little faster. 0.35 or 0.4 instead of 0.45 might do it. |
|
We can try 0.4 and go from there, what do you think? |
|
🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Unifies animation duration and easing metrics in the site editor animation. Specifically the Navigator and the View/Edit toggle.
Why?
I appreciate this may be subjective, hence the Try branch, but I find consistent timing / behavior across animations that are often experienced in close proximity creates a stronger feeling of cohesion in the design.
Testing Instructions
Screenshots or screencast
animation.mp4