Block Editor: Optimize 'Layout' controls #55754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
Mamaduka
requested review from
scruffian,
noisysocks and
tellthemachines
and removed request for
ellatrix
|
Size Change: -8 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f3b9a47. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6717185470
|
jsnajdr
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Nice optimization! Thanks for the continued work on removing redundant subscriptions.
In this file, the withLayoutStyles HOC could also be optimized. If the blockSupportsLayout value is false, the entire HOC effectively evaluates to a noop, and yet it does one useSelect call, one useSettings... There's also the useLayoutClasses hook call which is conditional (!) and therefore a potential crasher.
There's also withChildLayoutStyles with similar opportunities: if hasChildLayout is false, it's a noop.
|
Thank you, @jsnajdr. I'll do a follow-up for remaining optimizations.
I can't find a comment now, but I remember making this unconditional had some performance drawbacks. I'll see if that can be avoided. IIRC @youknowriad pointed this one out. Update: I found the conversation - #48900 (comment). |
|
The const shouldRenderLayoutStyles = ...;
if ( ! shouldRenderLayoutStyles ) {
return <BlockListBlock { ...props } />
}
return (
<BlockListBlockWithLayoutStyles
block={ BlockListBlock }
props={ props }
/>
);The same technique has been already used for |
|
Yes. That's what I did in #55762. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #55753.
A micro-optimization for
layoutcontrols to avoid calling theuseBlockEditingModehook for every block rendered in the editor.The controls were also calling the hook twice. The second call was redundant.
Why?
The check is only needed when the block supports Layout settings.
Tested using @jsnajdr's debug code (c029303), the store subscriptions are reduction by 1000 on large text post - 1000 blocks.
How?
PR moves block editing mode check inside the
LayoutPanelcomponent.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast